DD/Pogodnik
2
1
Fork 0
Code Issues Pull requests Releases Packages Activity

#27 test cache and update dependencies #32

Merged
Idvon merged 21 commits from issues-27 into main 2023-05-06 23:04:32 +00:00
Conversation 2 Commits 21 Files changed 12 +297 -189
Idvon commented 2023-05-02 20:06:50 +00:00
Member
Copy link

fix #27

fix #27
fix
All checks were successful
ci/woodpecker/push/woodpecker Pipeline was successful
Details
c3449aea59
fix tests
All checks were successful
ci/woodpecker/push/woodpecker Pipeline was successful
Details
e4fe6806fd
fix city name
Some checks failed
ci/woodpecker/push/woodpecker Pipeline failed
Details
fe078f7ac6
add test cache
Some checks failed
ci/woodpecker/push/woodpecker Pipeline failed
Details
77279851ec
fix
Some checks failed
ci/woodpecker/push/woodpecker Pipeline failed
Details
e9ee9398c4
fix poetry
All checks were successful
ci/woodpecker/push/woodpecker Pipeline was successful
Details
ffde202284
add test conclusion
Some checks failed
ci/woodpecker/push/woodpecker Pipeline failed
Details
c90089e922
fix
Some checks failed
ci/woodpecker/push/woodpecker Pipeline failed
Details
ee02d5de74
fix
Some checks failed
ci/woodpecker/push/woodpecker Pipeline failed
Details
06b8bb73d3
fix
Some checks failed
ci/woodpecker/push/woodpecker Pipeline failed
Details
917ac45404
fix
All checks were successful
ci/woodpecker/push/woodpecker Pipeline was successful
Details
6ea802af67
d requested changes 2023-05-06 19:43:25 +00:00
.gitignore
@ -1,5 +1,5 @@
*.json
*.toml
*.csv
*.sqlite3
d commented 2023-05-06 19:40:03 +00:00
Owner
Copy link

верни как было

верни как было
Idvon marked this conversation as resolved
Dockerfile
@ -3,3 +3,3 @@
COPY pyproject.toml /app
WORKDIR /app
ENV POETRY_VERSION=1.1.12
ENV POETRY_VERSION=1.4.2
d commented 2023-05-06 19:40:39 +00:00
Owner
Copy link

Добавь в название PR "update dependencies"

Добавь в название PR "update dependencies"
Idvon marked this conversation as resolved
tests/unit/constants.py
@ -2,0 +20,4 @@
LOCAL_CITY = GEO_CONFIG.city_name
LOCAL_TIMEOUT = 1
FREEZER.start()
d commented 2023-05-06 19:41:57 +00:00
Owner
Copy link

Мб обернуть в with freeze_time?

Мб обернуть в `with freeze_time`?
Idvon marked this conversation as resolved
tests/unit/src/geo/test_geocoding.py
@ -39,0 +23,4 @@
with requests_mock.Mocker() as m:
m.get(OW_GEO_URL, json=[])
requests.get(OW_GEO_URL).json()
d commented 2023-05-06 19:42:30 +00:00
Owner
Copy link

Эти три тут зачем? Вызывай их в соответствующих функциях тестов

Эти три тут зачем? Вызывай их в соответствующих функциях тестов
Idvon marked this conversation as resolved
Idvon changed title from #27 test cache to #27 test cache and update dependencies 2023-05-06 19:51:23 +00:00
fix
All checks were successful
ci/woodpecker/push/woodpecker Pipeline was successful
Details
ec0fa9acab
d approved these changes 2023-05-06 23:04:19 +00:00
Idvon merged commit aefb607e69 into main 2023-05-06 23:04:32 +00:00
Idvon deleted branch issues-27 2023-05-06 23:04:32 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
d
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

  
bug

Something is not working

  
enhancement

New feature

  
question

More information is needed

  
techdebt
No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
bug
enhancement
question
techdebt
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
DD/Pogodnik!32
No description provided.